Skip to content

[pluggable monitor] Add support for recipes to help platofrm development #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 8, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?
    Add support for pluggable monitor recipes in the form:
pluggable_monitor.pattern.PROTOCOL=RECIPE

These recipes are allowed only if a specific board is selected through the --fqbn flag.
This is mandatory because we need the board's preferences map to do the variable translation inside the RECIPE.

@cmaglie cmaglie changed the base branch from master to feature/pluggable-monitor October 8, 2021 15:58
@cmaglie cmaglie requested a review from silvanocerza October 8, 2021 15:58
@cmaglie cmaglie merged commit 605ea1b into arduino:feature/pluggable-monitor Oct 11, 2021
@cmaglie cmaglie deleted the pluggable-monitor-dev-rules branch October 11, 2021 12:32
d-a-v pushed a commit to d-a-v/arduino-cli that referenced this pull request Oct 14, 2021
* Add --fqbn parameter to monitor command

* Add support for pluggable monitors with explicit recipe in platform.txt

* increase logging

* fix i18n
d-a-v pushed a commit to d-a-v/arduino-cli that referenced this pull request Oct 14, 2021
* Add --fqbn parameter to monitor command

* Add support for pluggable monitors with explicit recipe in platform.txt

* increase logging

* fix i18n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants